This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
fs.writeFile behaviour not consistent with fs.write functions. #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Thanks! |
|
Hrm, I signed it before after making the pull request. Resubmitted now. On Sat, Jul 23, 2011 at 1:26 PM, koichik <
|
|
Thanks!! |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the write and writeSync methods both convert nonbuffer data to be written to a string when called, while writeFile and writeFileSync do not (the data is instead passed directly to the buffer constructor.) It seems inconsistent that
should produce different results than
seeing as how the created buffer from inside the function is never accessible to the caller.